Port random numbers to use wasip2 methods #612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catamorphism
force-pushed
the
wasip2-porting-random
branch
from
17e6672 to
6903c83
Compare
|
I'm debugging an issue where the new test I added fails with a release build ( |
catamorphism
force-pushed
the
wasip2-porting-random
branch
from
6903c83 to
97797de
Compare
|
Bug should be fixed now. |
pchickey
approved these changes
Aug 13, 2025
| wasip2_list_u8_t wasi_list; | ||
|
|
||
| // Get random bytes | ||
| random_get_random_bytes(len, &wasi_list); |
There was a problem hiding this comment.
I'm a little hesitant to handle this error by returning, vs exiting with EX_OSERR or something, since the docs of get-random-bytes guarantee that the wasi_list len will be equal to len. WDYT about exiting instead?
There was a problem hiding this comment.
That makes sense. Changed in cdcd442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.